Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user-agent to resteasy reactive client #22228

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Add user-agent to resteasy reactive client #22228

merged 1 commit into from
Dec 16, 2021
+67 −2

Conversation

stuartwdouglas
Copy link
Member

No description provided.

@geoand
Copy link
Contributor

geoand commented Dec 15, 2021

Hm... I did something more general in #22236

@FroMage
Copy link
Member

FroMage commented Dec 15, 2021

Well, you did something more general, and that's great, but it also doesn't set a User-Agent by default ;) So it doesn't fix my issue. I'm fairly sure that having a default one is the right thing to do.
Being able to override it with config is great too, but ideally we'd still have a default one, so probably we need both PRs :)

@geoand
Copy link
Contributor

geoand commented Dec 15, 2021

Sure, we can do both 😉

@stuartwdouglas
Copy link
Member Author

I think we probably want both.

@geoand geoand merged commit 8865895 into quarkusio:main Dec 16, 2021
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Dec 16, 2021
@FroMage FroMage mentioned this pull request Dec 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@FroMage FroMage Awaiting requested review from FroMage

Assignees
No one assigned
Labels
area/rest
Projects
None yet
Milestone
2.7.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartwdouglas @geoand @FroMage